Public Access
Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2f99599686 |
@@ -1,223 +1,82 @@
|
||||
using MeetingAssistant.Summary;
|
||||
using Microsoft.Extensions.AI;
|
||||
using System.Net;
|
||||
using System.Text;
|
||||
using System.Text.Json;
|
||||
|
||||
namespace MeetingAssistant.Tests;
|
||||
|
||||
public sealed class LiteLlmResponsesChatClientTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task ClientAssemblesStreamedTextResponseWithMetadataAndUsage()
|
||||
public void ParserIgnoresReasoningItemsWithNullStatusAndReadsText()
|
||||
{
|
||||
var handler = new SequencedHttpMessageHandler(
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
const string json = """
|
||||
{
|
||||
Content = new StringContent(
|
||||
"""
|
||||
data: {"type":"response.created","response":{"id":"resp_stream","created_at":1779147100,"model":"gpt-5.5","object":"response","output":[],"parallel_tool_calls":true,"status":"in_progress","store":false},"sequence_number":0}
|
||||
|
||||
data: {"type":"response.output_item.added","output_index":0,"item":{"id":"msg_stream","type":"message","status":"in_progress","content":[],"role":"assistant"},"sequence_number":1}
|
||||
|
||||
data: {"type":"response.content_part.added","item_id":"msg_stream","output_index":0,"content_index":0,"part":{"type":"output_text","annotations":[],"text":""},"sequence_number":2}
|
||||
|
||||
data: {"type":"response.output_text.delta","item_id":"msg_stream","output_index":0,"content_index":0,"delta":"Streamed OK","sequence_number":3}
|
||||
|
||||
data: {"type":"response.output_text.done","item_id":"msg_stream","output_index":0,"content_index":0,"text":"Streamed OK","sequence_number":4}
|
||||
|
||||
data: {"type":"response.content_part.done","item_id":"msg_stream","output_index":0,"content_index":0,"part":{"type":"output_text","annotations":[],"text":"Streamed OK"},"sequence_number":5}
|
||||
|
||||
data: {"type":"response.output_item.done","output_index":0,"item":{"id":"msg_stream","type":"message","status":"completed","content":[{"type":"output_text","annotations":[],"text":"Streamed OK"}],"role":"assistant"},"sequence_number":6}
|
||||
|
||||
data: {"type":"response.completed","response":{"id":"resp_stream","created_at":1779147100,"model":"gpt-5.5","object":"response","output":[],"parallel_tool_calls":true,"status":"completed","store":false,"usage":{"input_tokens":12,"output_tokens":3,"total_tokens":15}},"sequence_number":7}
|
||||
|
||||
data: [DONE]
|
||||
|
||||
""",
|
||||
Encoding.UTF8,
|
||||
"text/event-stream")
|
||||
});
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 0);
|
||||
|
||||
var response = await client.GetResponseAsync([new ChatMessage(ChatRole.User, "reply")]);
|
||||
|
||||
Assert.Equal("Streamed OK", response.Text);
|
||||
Assert.Equal("resp_stream", response.ResponseId);
|
||||
Assert.Equal("gpt-5.5", response.ModelId);
|
||||
Assert.Equal(DateTimeOffset.FromUnixTimeSeconds(1779147100), response.CreatedAt);
|
||||
Assert.NotNull(response.Usage);
|
||||
Assert.Equal(12, response.Usage.InputTokenCount);
|
||||
Assert.Equal(3, response.Usage.OutputTokenCount);
|
||||
Assert.Equal(15, response.Usage.TotalTokenCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ClientAssemblesStreamedFunctionCall()
|
||||
{
|
||||
var handler = new SequencedHttpMessageHandler(
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(
|
||||
"""
|
||||
data: {"type":"response.output_item.done","output_index":0,"item":{"type":"function_call","call_id":"call_stream","name":"write_summary","arguments":"{\"markdown\":\"# Summary\\nDone\"}","status":"completed"}}
|
||||
|
||||
data: {"type":"response.completed","response":{"id":"resp_stream","model":"gpt-5.5","output":[]}}
|
||||
|
||||
data: [DONE]
|
||||
|
||||
""",
|
||||
Encoding.UTF8,
|
||||
"text/event-stream")
|
||||
});
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 0);
|
||||
|
||||
var response = await client.GetResponseAsync([new ChatMessage(ChatRole.User, "write summary")]);
|
||||
var call = Assert.IsType<FunctionCallContent>(Assert.Single(response.Messages[0].Contents));
|
||||
|
||||
Assert.Equal("call_stream", call.CallId);
|
||||
Assert.Equal("write_summary", call.Name);
|
||||
Assert.NotNull(call.Arguments);
|
||||
Assert.Equal("# Summary\nDone", call.Arguments["markdown"]?.ToString());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ClientUsesNonStreamingResponsesWhenConfigured()
|
||||
{
|
||||
var handler = new RecordingHttpMessageHandler(_ => new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(
|
||||
"""
|
||||
"id": "resp_test",
|
||||
"created_at": 1779147100,
|
||||
"model": "gpt-5.5-2026-04-23",
|
||||
"output": [
|
||||
{
|
||||
"id": "resp_nonstream",
|
||||
"created_at": 1779147100,
|
||||
"model": "gpt-5.5",
|
||||
"object": "response",
|
||||
"output": [
|
||||
{
|
||||
"id": "msg_nonstream",
|
||||
"type": "message",
|
||||
"status": "completed",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"annotations": [],
|
||||
"text": "Non-streamed OK"
|
||||
}
|
||||
],
|
||||
"role": "assistant"
|
||||
}
|
||||
],
|
||||
"parallel_tool_calls": true,
|
||||
"type": "reasoning",
|
||||
"summary": [],
|
||||
"status": null
|
||||
},
|
||||
{
|
||||
"type": "message",
|
||||
"role": "assistant",
|
||||
"status": "completed",
|
||||
"store": false,
|
||||
"usage": {
|
||||
"input_tokens": 12,
|
||||
"output_tokens": 4,
|
||||
"total_tokens": 16
|
||||
}
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "OK"
|
||||
}
|
||||
]
|
||||
}
|
||||
""",
|
||||
Encoding.UTF8,
|
||||
"application/json")
|
||||
});
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 0, useStreaming: false);
|
||||
]
|
||||
}
|
||||
""";
|
||||
|
||||
var response = await client.GetResponseAsync([new ChatMessage(ChatRole.User, "reply")]);
|
||||
var response = LiteLlmResponsesChatClient.ParseResponseJson(json);
|
||||
|
||||
Assert.Equal("Non-streamed OK", response.Text);
|
||||
Assert.Contains("\"stream\":false", Assert.Single(handler.RequestBodies));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ClientSendsChatMessagesAsResponsesMessageItems()
|
||||
{
|
||||
var handler = new RecordingHttpMessageHandler(_ => CreateStreamedTextResponse("Done."));
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 0);
|
||||
|
||||
await client.GetResponseAsync(
|
||||
[
|
||||
new ChatMessage(ChatRole.User, "write summary"),
|
||||
new ChatMessage(ChatRole.Assistant, "I will inspect the meeting.")
|
||||
]);
|
||||
|
||||
using var request = JsonDocument.Parse(Assert.Single(handler.RequestBodies));
|
||||
var inputItems = request.RootElement.GetProperty("input").EnumerateArray().ToArray();
|
||||
Assert.Equal(2, inputItems.Length);
|
||||
Assert.All(inputItems, item => Assert.Equal("message", item.GetProperty("type").GetString()));
|
||||
Assert.Equal("user", inputItems[0].GetProperty("role").GetString());
|
||||
Assert.Equal(
|
||||
"input_text",
|
||||
Assert.Single(inputItems[0].GetProperty("content").EnumerateArray())
|
||||
.GetProperty("type")
|
||||
.GetString());
|
||||
Assert.Equal("assistant", inputItems[1].GetProperty("role").GetString());
|
||||
Assert.Equal(
|
||||
"output_text",
|
||||
Assert.Single(inputItems[1].GetProperty("content").EnumerateArray())
|
||||
.GetProperty("type")
|
||||
.GetString());
|
||||
Assert.DoesNotContain("\"type\":\"unknown\"", handler.RequestBodies[0]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AgentLoopReturnsMalformedFunctionArgumentsWithoutInvokingTool()
|
||||
{
|
||||
var responses = new Queue<HttpResponseMessage>(
|
||||
[
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(
|
||||
"""
|
||||
data: {"type":"response.output_item.done","output_index":0,"item":{"type":"function_call","call_id":"call_invalid","name":"write_summary","arguments":"{not-json","status":"completed"}}
|
||||
|
||||
data: {"type":"response.completed","response":{"id":"resp_invalid","model":"gpt-5.5","output":[]}}
|
||||
|
||||
data: [DONE]
|
||||
|
||||
""",
|
||||
Encoding.UTF8,
|
||||
"text/event-stream")
|
||||
},
|
||||
CreateStreamedTextResponse("Recovered.")
|
||||
]);
|
||||
var handler = new RecordingHttpMessageHandler(_ => responses.Dequeue());
|
||||
var toolInvoked = false;
|
||||
var tool = AIFunctionFactory.Create(
|
||||
(string markdown) =>
|
||||
{
|
||||
toolInvoked = true;
|
||||
return markdown;
|
||||
},
|
||||
"write_summary",
|
||||
"Writes a summary.");
|
||||
using var innerClient = CreateClient(handler, reconnectionAttempts: 0);
|
||||
using var functionClient = innerClient
|
||||
.AsBuilder()
|
||||
.UseFunctionInvocation(
|
||||
loggerFactory: null,
|
||||
client => client.FunctionInvoker = FunctionInvocationGuard.InvokeAsync)
|
||||
.Build();
|
||||
|
||||
var response = await functionClient.GetResponseAsync(
|
||||
[new ChatMessage(ChatRole.User, "write summary")],
|
||||
new ChatOptions { Tools = [tool] });
|
||||
|
||||
Assert.False(toolInvoked);
|
||||
Assert.Equal("Recovered.", response.Text);
|
||||
Assert.Equal(2, handler.RequestBodies.Count);
|
||||
Assert.Contains("invalid_tool_arguments", handler.RequestBodies[1]);
|
||||
Assert.Contains("call_invalid", handler.RequestBodies[1]);
|
||||
Assert.Equal("OK", response.Text);
|
||||
Assert.Equal("resp_test", response.ResponseId);
|
||||
Assert.Equal("gpt-5.5-2026-04-23", response.ModelId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ClientReportsVisibleReasoningSummariesSeparatelyFromResponseText()
|
||||
{
|
||||
var handler = new SequencedHttpMessageHandler(
|
||||
CreateStreamedTextResponse(
|
||||
"Done.",
|
||||
"Checked the configured rules file.",
|
||||
"Prepared a targeted update."));
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "reasoning",
|
||||
"summary": [
|
||||
{
|
||||
"type": "summary_text",
|
||||
"text": "Checked the configured rules file."
|
||||
},
|
||||
{
|
||||
"type": "summary_text",
|
||||
"text": "Prepared a targeted update."
|
||||
}
|
||||
]
|
||||
},
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
});
|
||||
var reasoningSummaries = new List<string>();
|
||||
using var client = CreateClient(
|
||||
handler,
|
||||
@@ -239,7 +98,33 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
public async Task ClientDoesNotFailResponseWhenReasoningSummaryCallbackFails()
|
||||
{
|
||||
var handler = new SequencedHttpMessageHandler(
|
||||
CreateStreamedTextResponse("Done.", "Checked the configured rules file."));
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "reasoning",
|
||||
"summary": [
|
||||
{
|
||||
"type": "summary_text",
|
||||
"text": "Checked the configured rules file."
|
||||
}
|
||||
]
|
||||
},
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
});
|
||||
using var client = CreateClient(
|
||||
handler,
|
||||
reconnectionAttempts: 0,
|
||||
@@ -250,6 +135,64 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
Assert.Equal("Done.", response.Text);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParserReadsFunctionCalls()
|
||||
{
|
||||
const string json = """
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "function_call",
|
||||
"call_id": "call_1",
|
||||
"name": "write_summary",
|
||||
"arguments": "{\"markdown\":\"# Summary\\nDone\"}",
|
||||
"status": "completed"
|
||||
}
|
||||
]
|
||||
}
|
||||
""";
|
||||
|
||||
var response = LiteLlmResponsesChatClient.ParseResponseJson(json);
|
||||
var call = Assert.IsType<FunctionCallContent>(Assert.Single(response.Messages[0].Contents));
|
||||
|
||||
Assert.Equal("call_1", call.CallId);
|
||||
Assert.Equal("write_summary", call.Name);
|
||||
Assert.NotNull(call.Arguments);
|
||||
Assert.Equal("# Summary\nDone", call.Arguments["markdown"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParserReadsUsage()
|
||||
{
|
||||
const string json = """
|
||||
{
|
||||
"usage": {
|
||||
"input_tokens": 123,
|
||||
"output_tokens": 45,
|
||||
"total_tokens": 168
|
||||
},
|
||||
"output": [
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "OK"
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""";
|
||||
|
||||
var response = LiteLlmResponsesChatClient.ParseResponseJson(json);
|
||||
|
||||
Assert.NotNull(response.Usage);
|
||||
Assert.Equal(123, response.Usage.InputTokenCount);
|
||||
Assert.Equal(45, response.Usage.OutputTokenCount);
|
||||
Assert.Equal(168, response.Usage.TotalTokenCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ClientRetriesTransientServerFailure()
|
||||
{
|
||||
@@ -258,7 +201,24 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
{
|
||||
Content = new StringContent("Internal Server Error")
|
||||
},
|
||||
CreateStreamedTextResponse("Done."));
|
||||
new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
});
|
||||
var retryCount = 0;
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 1, retrying: () => retryCount++);
|
||||
|
||||
@@ -289,7 +249,24 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
[Fact]
|
||||
public async Task ClientSendsUserInitiatorOnceThenAgentInitiator()
|
||||
{
|
||||
var handler = new RecordingHttpMessageHandler(_ => CreateStreamedTextResponse("Done."));
|
||||
var handler = new RecordingHttpMessageHandler(_ => new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
});
|
||||
using var client = CreateClient(handler, reconnectionAttempts: 0);
|
||||
|
||||
await client.GetResponseAsync([new ChatMessage(ChatRole.User, "write summary")]);
|
||||
@@ -321,7 +298,24 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
};
|
||||
}
|
||||
|
||||
return CreateStreamedTextResponse("Done.");
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
};
|
||||
});
|
||||
using var client = CreateClient(
|
||||
handler,
|
||||
@@ -356,7 +350,24 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
};
|
||||
}
|
||||
|
||||
return CreateStreamedTextResponse("Done.");
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"output": [
|
||||
{
|
||||
"type": "message",
|
||||
"content": [
|
||||
{
|
||||
"type": "output_text",
|
||||
"text": "Done."
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
""")
|
||||
};
|
||||
});
|
||||
using var client = CreateClient(
|
||||
handler,
|
||||
@@ -389,8 +400,7 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
int reconnectionAttempts,
|
||||
LiteLlmResponsesCompactionOptions? compactionOptions = null,
|
||||
Action? retrying = null,
|
||||
Action<string>? reasoningSummaryChanged = null,
|
||||
bool useStreaming = true)
|
||||
Action<string>? reasoningSummaryChanged = null)
|
||||
{
|
||||
return new LiteLlmResponsesChatClient(
|
||||
new HttpClient(handler)
|
||||
@@ -405,49 +415,7 @@ public sealed class LiteLlmResponsesChatClientTests
|
||||
TimeSpan.Zero,
|
||||
compactionOptions,
|
||||
retrying: retrying,
|
||||
reasoningSummaryChanged: reasoningSummaryChanged,
|
||||
useStreaming: useStreaming);
|
||||
}
|
||||
|
||||
private static HttpResponseMessage CreateStreamedTextResponse(
|
||||
string text,
|
||||
params string[] reasoningSummaries)
|
||||
{
|
||||
var events = new List<string>();
|
||||
for (var index = 0; index < reasoningSummaries.Length; index++)
|
||||
{
|
||||
events.Add("data: " + JsonSerializer.Serialize(new
|
||||
{
|
||||
type = "response.reasoning_summary_text.delta",
|
||||
item_id = "reasoning_stream",
|
||||
output_index = 0,
|
||||
summary_index = index,
|
||||
delta = reasoningSummaries[index]
|
||||
}));
|
||||
}
|
||||
|
||||
var outputIndex = reasoningSummaries.Length > 0 ? 1 : 0;
|
||||
events.Add("data: " + JsonSerializer.Serialize(new
|
||||
{
|
||||
type = "response.output_text.delta",
|
||||
item_id = "msg_stream",
|
||||
output_index = outputIndex,
|
||||
content_index = 0,
|
||||
delta = text
|
||||
}));
|
||||
events.Add(
|
||||
"""data: {"type":"response.completed","response":{"id":"resp_stream","created_at":1779147100,"model":"gpt-5.5","object":"response","output":[],"parallel_tool_calls":true,"status":"completed","store":false,"usage":{"input_tokens":12,"output_tokens":3,"total_tokens":15}}}""");
|
||||
events.Add("data: [DONE]");
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(
|
||||
string.Join($"{Environment.NewLine}{Environment.NewLine}", events)
|
||||
+ Environment.NewLine
|
||||
+ Environment.NewLine,
|
||||
Encoding.UTF8,
|
||||
"text/event-stream")
|
||||
};
|
||||
reasoningSummaryChanged: reasoningSummaryChanged);
|
||||
}
|
||||
|
||||
private sealed class SequencedHttpMessageHandler : HttpMessageHandler
|
||||
|
||||
@@ -20,7 +20,6 @@ public sealed class WorkflowRulesEditorTests
|
||||
Key = "summary-key",
|
||||
KeyEnv = "SUMMARY_KEY",
|
||||
Model = "summary-model",
|
||||
UseStreaming = true,
|
||||
EnableThinking = true,
|
||||
ReasoningEffort = ReasoningEffortOption.High,
|
||||
ReconnectionAttempts = 7,
|
||||
@@ -34,7 +33,6 @@ public sealed class WorkflowRulesEditorTests
|
||||
var editor = new WorkflowRulesEditorOptions
|
||||
{
|
||||
Model = "editor-model",
|
||||
UseStreaming = false,
|
||||
EnableThinking = false,
|
||||
MaxOutputTokens = 50
|
||||
};
|
||||
@@ -45,7 +43,6 @@ public sealed class WorkflowRulesEditorTests
|
||||
Assert.Equal("summary-key", effective.Key);
|
||||
Assert.Equal("SUMMARY_KEY", effective.KeyEnv);
|
||||
Assert.Equal("editor-model", effective.Model);
|
||||
Assert.False(effective.UseStreaming);
|
||||
Assert.False(effective.EnableThinking);
|
||||
Assert.Equal(ReasoningEffortOption.High, effective.ReasoningEffort);
|
||||
Assert.Equal(7, effective.ReconnectionAttempts);
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
<Nullable>enable</Nullable>
|
||||
<ImplicitUsings>enable</ImplicitUsings>
|
||||
<PreserveCompilationContext>true</PreserveCompilationContext>
|
||||
<MicrosoftSpeechVersion>1.50.0</MicrosoftSpeechVersion>
|
||||
<MicrosoftSpeechVersion>1.51.0</MicrosoftSpeechVersion>
|
||||
</PropertyGroup>
|
||||
|
||||
<PropertyGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">
|
||||
@@ -20,7 +20,7 @@
|
||||
</ItemGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<PackageReference Include="Microsoft.Agents.AI.OpenAI" Version="1.16.0" />
|
||||
<PackageReference Include="Microsoft.Agents.AI.OpenAI" Version="1.13.0" />
|
||||
<PackageReference Include="DiffPlex" Version="1.9.0" />
|
||||
<PackageReference Include="Microsoft.CognitiveServices.Speech" Version="$(MicrosoftSpeechVersion)" />
|
||||
<PackageReference Include="Microsoft.CognitiveServices.Speech.Extension.MAS" Version="$(MicrosoftSpeechVersion)" ExcludeAssets="build" />
|
||||
@@ -28,7 +28,7 @@
|
||||
<PackageReference Include="NAudio" Version="2.3.0" />
|
||||
<PackageReference Include="NCalcSync" Version="6.4.0" />
|
||||
<PackageReference Include="RazorLight" Version="2.3.1" />
|
||||
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.5" />
|
||||
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.3" />
|
||||
<PackageReference Include="System.Drawing.Common" Version="10.0.10" />
|
||||
<PackageReference Include="Whisper.net" Version="1.9.1" />
|
||||
<PackageReference Include="Whisper.net.Runtime" Version="1.9.1" />
|
||||
|
||||
@@ -383,8 +383,6 @@ public sealed class AgentOptions
|
||||
|
||||
public string Model { get; set; } = "chatgpt/gpt-5.5";
|
||||
|
||||
public bool UseStreaming { get; set; } = true;
|
||||
|
||||
public bool EnableThinking { get; set; } = true;
|
||||
|
||||
public ReasoningEffortOption ReasoningEffort { get; set; } = ReasoningEffortOption.Medium;
|
||||
@@ -416,8 +414,6 @@ public sealed class WorkflowRulesEditorOptions
|
||||
|
||||
public string? Model { get; set; }
|
||||
|
||||
public bool? UseStreaming { get; set; }
|
||||
|
||||
public bool? EnableThinking { get; set; }
|
||||
|
||||
public ReasoningEffortOption? ReasoningEffort { get; set; }
|
||||
@@ -446,7 +442,6 @@ public sealed class WorkflowRulesEditorOptions
|
||||
Key = string.IsNullOrWhiteSpace(Key) ? defaults.Key : Key,
|
||||
KeyEnv = string.IsNullOrWhiteSpace(KeyEnv) ? defaults.KeyEnv : KeyEnv!,
|
||||
Model = string.IsNullOrWhiteSpace(Model) ? defaults.Model : Model!,
|
||||
UseStreaming = UseStreaming ?? defaults.UseStreaming,
|
||||
EnableThinking = EnableThinking ?? defaults.EnableThinking,
|
||||
ReasoningEffort = ReasoningEffort ?? defaults.ReasoningEffort,
|
||||
ReconnectionAttempts = ReconnectionAttempts ?? defaults.ReconnectionAttempts,
|
||||
|
||||
@@ -1,26 +0,0 @@
|
||||
using System.Text.Json.Nodes;
|
||||
using Microsoft.Extensions.AI;
|
||||
|
||||
namespace MeetingAssistant.Summary;
|
||||
|
||||
internal static class FunctionInvocationGuard
|
||||
{
|
||||
public static ValueTask<object?> InvokeAsync(
|
||||
FunctionInvocationContext context,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
if (context.CallContent.Exception is not null)
|
||||
{
|
||||
return ValueTask.FromResult<object?>(new JsonObject
|
||||
{
|
||||
["error"] = new JsonObject
|
||||
{
|
||||
["code"] = "invalid_tool_arguments",
|
||||
["message"] = "Tool arguments must be a valid JSON object."
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
return context.Function.InvokeAsync(context.Arguments, cancellationToken);
|
||||
}
|
||||
}
|
||||
@@ -1,28 +1,20 @@
|
||||
using System.Net.Http.Headers;
|
||||
using System.ClientModel;
|
||||
using System.ClientModel.Primitives;
|
||||
using System.Text;
|
||||
using System.Text.Json;
|
||||
using System.Text.Json.Nodes;
|
||||
using Microsoft.Agents.AI.Compaction;
|
||||
using Microsoft.Extensions.AI;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using OpenAI;
|
||||
using OpenAI.Responses;
|
||||
|
||||
namespace MeetingAssistant.Summary;
|
||||
|
||||
#pragma warning disable MAAI001
|
||||
#pragma warning disable OPENAI001
|
||||
public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
{
|
||||
private static readonly JsonSerializerOptions JsonOptions = new(JsonSerializerDefaults.Web);
|
||||
|
||||
private readonly HttpClient httpClient;
|
||||
private readonly ResponsesClient responsesClient;
|
||||
private readonly AsyncLocal<string?> requestInitiator = new();
|
||||
private readonly string model;
|
||||
private readonly bool useStreaming;
|
||||
private readonly bool enableThinking;
|
||||
private readonly string reasoningEffort;
|
||||
private readonly int reconnectionAttempts;
|
||||
@@ -45,8 +37,7 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
ILogger? logger = null,
|
||||
bool firstRequestIsUser = true,
|
||||
Action? retrying = null,
|
||||
Action<string>? reasoningSummaryChanged = null,
|
||||
bool useStreaming = true)
|
||||
Action<string>? reasoningSummaryChanged = null)
|
||||
: this(
|
||||
new HttpClient { BaseAddress = NormalizeEndpoint(endpoint) },
|
||||
apiKey,
|
||||
@@ -59,8 +50,7 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
logger,
|
||||
firstRequestIsUser,
|
||||
retrying,
|
||||
reasoningSummaryChanged,
|
||||
useStreaming)
|
||||
reasoningSummaryChanged)
|
||||
{
|
||||
}
|
||||
|
||||
@@ -76,14 +66,11 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
ILogger? logger = null,
|
||||
bool firstRequestIsUser = true,
|
||||
Action? retrying = null,
|
||||
Action<string>? reasoningSummaryChanged = null,
|
||||
bool useStreaming = true)
|
||||
Action<string>? reasoningSummaryChanged = null)
|
||||
{
|
||||
this.httpClient = httpClient;
|
||||
this.httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", apiKey);
|
||||
responsesClient = CreateResponsesClient(httpClient, apiKey, requestInitiator);
|
||||
this.model = model;
|
||||
this.useStreaming = useStreaming;
|
||||
this.enableThinking = enableThinking;
|
||||
this.reasoningEffort = reasoningEffort;
|
||||
this.reconnectionAttempts = Math.Max(0, reconnectionAttempts);
|
||||
@@ -100,50 +87,20 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
httpClient.Dispose();
|
||||
}
|
||||
|
||||
internal static LiteLlmResponsesChatClient Create(
|
||||
AgentOptions options,
|
||||
string apiKey,
|
||||
LiteLlmResponsesCompactionOptions? compactionOptions,
|
||||
ILogger? logger,
|
||||
bool firstRequestIsUser,
|
||||
Action? retrying = null,
|
||||
Action<string>? reasoningSummaryChanged = null)
|
||||
{
|
||||
return new LiteLlmResponsesChatClient(
|
||||
new Uri(options.Endpoint),
|
||||
apiKey,
|
||||
options.Model,
|
||||
options.EnableThinking,
|
||||
options.ReasoningEffort switch
|
||||
{
|
||||
ReasoningEffortOption.None => "none",
|
||||
ReasoningEffortOption.Low => "low",
|
||||
ReasoningEffortOption.High => "high",
|
||||
ReasoningEffortOption.ExtraHigh => "xhigh",
|
||||
_ => "medium"
|
||||
},
|
||||
options.ReconnectionAttempts,
|
||||
options.ReconnectionDelay,
|
||||
compactionOptions,
|
||||
logger,
|
||||
firstRequestIsUser,
|
||||
retrying,
|
||||
reasoningSummaryChanged,
|
||||
options.UseStreaming);
|
||||
}
|
||||
|
||||
public async Task<ChatResponse> GetResponseAsync(
|
||||
IEnumerable<ChatMessage> messages,
|
||||
ChatOptions? options = null,
|
||||
CancellationToken cancellationToken = default)
|
||||
{
|
||||
var payload = await CreateCompactedPayloadAsync(messages.ToList(), options, cancellationToken).ConfigureAwait(false);
|
||||
var result = await PostWithRetryAsync(payload, cancellationToken).ConfigureAwait(false);
|
||||
ReportVisibleReasoningSummaries(result.ReasoningSummaries);
|
||||
LogResponseDiagnostics(result.Response);
|
||||
ThrowIfResponseHasNoContent(result.Response);
|
||||
LogResponseUsage(result.Response.Usage);
|
||||
return result.Response;
|
||||
var responseJson = await PostWithRetryAsync(payload, cancellationToken).ConfigureAwait(false);
|
||||
|
||||
var response = ParseResponseJson(responseJson, out var reasoningSummaries);
|
||||
ReportVisibleReasoningSummaries(reasoningSummaries);
|
||||
LogResponseDiagnostics(responseJson, response);
|
||||
ThrowIfResponseHasNoContent(responseJson, response);
|
||||
LogResponseUsage(response.Usage);
|
||||
return response;
|
||||
}
|
||||
|
||||
public async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseAsync(
|
||||
@@ -170,14 +127,79 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
: null;
|
||||
}
|
||||
|
||||
private static IReadOnlyList<string> ExtractVisibleReasoningSummaries(ChatResponse response)
|
||||
public static ChatResponse ParseResponseJson(string responseJson)
|
||||
{
|
||||
return response.Messages
|
||||
.SelectMany(message => message.Contents)
|
||||
.OfType<TextReasoningContent>()
|
||||
.Select(content => content.Text)
|
||||
.Where(text => !string.IsNullOrWhiteSpace(text))
|
||||
.ToArray();
|
||||
return ParseResponseJson(responseJson, out _);
|
||||
}
|
||||
|
||||
private static ChatResponse ParseResponseJson(
|
||||
string responseJson,
|
||||
out IReadOnlyList<string> reasoningSummaries)
|
||||
{
|
||||
using var document = JsonDocument.Parse(responseJson);
|
||||
var root = document.RootElement;
|
||||
var contents = new List<AIContent>();
|
||||
reasoningSummaries = ExtractVisibleReasoningSummaries(root);
|
||||
|
||||
if (root.TryGetProperty("output", out var output) && output.ValueKind == JsonValueKind.Array)
|
||||
{
|
||||
foreach (var item in output.EnumerateArray())
|
||||
{
|
||||
var type = GetString(item, "type");
|
||||
if (type == "message")
|
||||
{
|
||||
AddMessageContent(contents, item);
|
||||
}
|
||||
else if (type == "function_call")
|
||||
{
|
||||
contents.Add(new FunctionCallContent(
|
||||
GetRequiredString(item, "call_id"),
|
||||
GetRequiredString(item, "name"),
|
||||
ParseArguments(GetString(item, "arguments"))));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
var message = new ChatMessage
|
||||
{
|
||||
Role = ChatRole.Assistant,
|
||||
Contents = contents
|
||||
};
|
||||
|
||||
return new ChatResponse(message)
|
||||
{
|
||||
ResponseId = GetString(root, "id"),
|
||||
ModelId = GetString(root, "model"),
|
||||
CreatedAt = GetUnixTimestamp(root, "created_at"),
|
||||
Usage = ParseUsage(root),
|
||||
RawRepresentation = responseJson
|
||||
};
|
||||
}
|
||||
|
||||
internal static IReadOnlyList<string> ExtractVisibleReasoningSummaries(string responseJson)
|
||||
{
|
||||
using var document = JsonDocument.Parse(responseJson);
|
||||
return ExtractVisibleReasoningSummaries(document.RootElement);
|
||||
}
|
||||
|
||||
private static IReadOnlyList<string> ExtractVisibleReasoningSummaries(JsonElement root)
|
||||
{
|
||||
var summaries = new List<string>();
|
||||
|
||||
if (!root.TryGetProperty("output", out var output) || output.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
return summaries;
|
||||
}
|
||||
|
||||
foreach (var item in output.EnumerateArray())
|
||||
{
|
||||
if (GetString(item, "type") == "reasoning")
|
||||
{
|
||||
AddVisibleReasoningSummaryText(summaries, item);
|
||||
}
|
||||
}
|
||||
|
||||
return summaries;
|
||||
}
|
||||
|
||||
private void ReportVisibleReasoningSummaries(IReadOnlyList<string> summaries)
|
||||
@@ -385,9 +407,7 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
return payload;
|
||||
}
|
||||
|
||||
private async Task<ResponsesChatResult> PostWithRetryAsync(
|
||||
JsonObject payload,
|
||||
CancellationToken cancellationToken)
|
||||
private async Task<string> PostWithRetryAsync(JsonObject payload, CancellationToken cancellationToken)
|
||||
{
|
||||
var payloadJson = payload.ToJsonString(JsonOptions);
|
||||
Exception? lastException = null;
|
||||
@@ -398,36 +418,26 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
{
|
||||
var initiator = NextInitiator();
|
||||
LogRequestDiagnostics(payload, initiator, attempt);
|
||||
using var request = CreateJsonRequest(
|
||||
"responses",
|
||||
payloadJson,
|
||||
initiator);
|
||||
using var response = await httpClient.SendAsync(request, cancellationToken).ConfigureAwait(false);
|
||||
var responseJson = await response.Content.ReadAsStringAsync(cancellationToken).ConfigureAwait(false);
|
||||
|
||||
var createOptions = ModelReaderWriter.Read<CreateResponseOptions>(
|
||||
BinaryData.FromString(payloadJson),
|
||||
ModelReaderWriterOptions.Json)
|
||||
?? throw new InvalidOperationException("Unable to create OpenAI Responses request options.");
|
||||
createOptions.StreamingEnabled = useStreaming;
|
||||
if (response.IsSuccessStatusCode)
|
||||
{
|
||||
return responseJson;
|
||||
}
|
||||
|
||||
var previousInitiator = requestInitiator.Value;
|
||||
requestInitiator.Value = initiator;
|
||||
try
|
||||
var exception = new InvalidOperationException(
|
||||
$"LiteLLM Responses request failed with {(int)response.StatusCode} {response.ReasonPhrase}: {responseJson}");
|
||||
if (!IsRetryableStatusCode((int)response.StatusCode) || attempt == reconnectionAttempts)
|
||||
{
|
||||
return useStreaming
|
||||
? await GetStreamingResponseAsync(createOptions, cancellationToken).ConfigureAwait(false)
|
||||
: CreateNonStreamingResult((await responsesClient
|
||||
.CreateResponseAsync(createOptions, cancellationToken)
|
||||
.ConfigureAwait(false))
|
||||
.Value
|
||||
.AsChatResponse(createOptions));
|
||||
throw exception;
|
||||
}
|
||||
finally
|
||||
{
|
||||
requestInitiator.Value = previousInitiator;
|
||||
}
|
||||
}
|
||||
catch (ClientResultException exception)
|
||||
when (!IsRetryableStatusCode(exception.Status) || attempt == reconnectionAttempts)
|
||||
{
|
||||
throw new InvalidOperationException(
|
||||
$"LiteLLM Responses request failed with {exception.Status}: {exception.Message}",
|
||||
exception);
|
||||
|
||||
lastException = exception;
|
||||
}
|
||||
catch (Exception exception) when (IsRetryableException(exception) && attempt < reconnectionAttempts)
|
||||
{
|
||||
@@ -441,48 +451,6 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
throw lastException ?? new InvalidOperationException("LiteLLM Responses request failed.");
|
||||
}
|
||||
|
||||
private async Task<ResponsesChatResult> GetStreamingResponseAsync(
|
||||
CreateResponseOptions createOptions,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
var updates = new List<ChatResponseUpdate>();
|
||||
var reasoningSummaries = new Dictionary<(string ItemId, int SummaryIndex), StringBuilder>();
|
||||
await foreach (var update in responsesClient
|
||||
.CreateResponseStreamingAsync(createOptions, cancellationToken)
|
||||
.AsChatResponseUpdatesAsync(createOptions, cancellationToken)
|
||||
.ConfigureAwait(false))
|
||||
{
|
||||
updates.Add(update);
|
||||
var reasoningUpdate = update.RawRepresentation
|
||||
as StreamingResponseReasoningSummaryTextDeltaUpdate;
|
||||
if (reasoningUpdate is null)
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var key = (reasoningUpdate.ItemId, reasoningUpdate.SummaryIndex);
|
||||
if (!reasoningSummaries.TryGetValue(key, out var summary))
|
||||
{
|
||||
summary = new StringBuilder();
|
||||
reasoningSummaries[key] = summary;
|
||||
}
|
||||
|
||||
summary.Append(reasoningUpdate.Delta);
|
||||
}
|
||||
|
||||
return new ResponsesChatResult(
|
||||
updates.ToChatResponse(),
|
||||
reasoningSummaries.Values
|
||||
.Select(summary => summary.ToString())
|
||||
.Where(summary => !string.IsNullOrWhiteSpace(summary))
|
||||
.ToArray());
|
||||
}
|
||||
|
||||
private static ResponsesChatResult CreateNonStreamingResult(ChatResponse response)
|
||||
{
|
||||
return new ResponsesChatResult(response, ExtractVisibleReasoningSummaries(response));
|
||||
}
|
||||
|
||||
private HttpRequestMessage CreateJsonRequest(
|
||||
string requestUri,
|
||||
string payloadJson,
|
||||
@@ -521,9 +489,7 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
|
||||
private static bool IsRetryableException(Exception exception)
|
||||
{
|
||||
return exception is ClientResultException clientException
|
||||
&& IsRetryableStatusCode(clientException.Status)
|
||||
|| exception is HttpRequestException or TaskCanceledException;
|
||||
return exception is HttpRequestException or TaskCanceledException;
|
||||
}
|
||||
|
||||
private void LogContextWindow(int estimatedTokens, bool compacted, string source)
|
||||
@@ -595,18 +561,18 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
instructionsPreview);
|
||||
}
|
||||
|
||||
private void LogResponseDiagnostics(ChatResponse response)
|
||||
private void LogResponseDiagnostics(string responseJson, ChatResponse response)
|
||||
{
|
||||
if (logger is null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var outputTypes = GetOutputItemTypes(responseJson);
|
||||
var parsedTypes = response.Messages
|
||||
.SelectMany(message => message.Contents)
|
||||
.Select(content => content.GetType().Name)
|
||||
.ToArray();
|
||||
var outputTypes = GetOutputItemTypes(response);
|
||||
var functionCalls = response.Messages
|
||||
.SelectMany(message => message.Contents)
|
||||
.OfType<FunctionCallContent>()
|
||||
@@ -624,29 +590,40 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
if (parsedTypes.Length == 0)
|
||||
{
|
||||
logger.LogWarning(
|
||||
"LiteLLM Responses response contained no parseable message text or function calls.");
|
||||
"LiteLLM Responses response contained no parseable message text or function calls. Raw response preview: {ResponsePreview}",
|
||||
Truncate(responseJson, maxLength: 6000));
|
||||
}
|
||||
}
|
||||
|
||||
private static void ThrowIfResponseHasNoContent(ChatResponse response)
|
||||
private static void ThrowIfResponseHasNoContent(string responseJson, ChatResponse response)
|
||||
{
|
||||
if (response.Messages.SelectMany(message => message.Contents).Any())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var outputTypes = GetOutputItemTypes(response);
|
||||
var outputTypes = GetOutputItemTypes(responseJson);
|
||||
throw new InvalidOperationException(
|
||||
"LiteLLM Responses returned no parseable message text or function calls. " +
|
||||
$"ResponseId={response.ResponseId ?? "<none>"}, outputTypes=[{string.Join(", ", outputTypes)}].");
|
||||
}
|
||||
|
||||
private static string[] GetOutputItemTypes(ChatResponse response)
|
||||
private static string[] GetOutputItemTypes(string responseJson)
|
||||
{
|
||||
return response.Messages
|
||||
.SelectMany(message => message.Contents)
|
||||
.Select(content => content.RawRepresentation?.GetType().Name ?? content.GetType().Name)
|
||||
.ToArray();
|
||||
try
|
||||
{
|
||||
using var document = JsonDocument.Parse(responseJson);
|
||||
return document.RootElement.TryGetProperty("output", out var output) && output.ValueKind == JsonValueKind.Array
|
||||
? output
|
||||
.EnumerateArray()
|
||||
.Select(item => GetString(item, "type") ?? item.ValueKind.ToString())
|
||||
.ToArray()
|
||||
: [];
|
||||
}
|
||||
catch (JsonException)
|
||||
{
|
||||
return ["<invalid-json>"];
|
||||
}
|
||||
}
|
||||
|
||||
private static string Truncate(string value, int maxLength)
|
||||
@@ -672,19 +649,10 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(text))
|
||||
{
|
||||
var isAssistant = role == ChatRole.Assistant.Value;
|
||||
input.Add(new JsonObject
|
||||
{
|
||||
["type"] = "message",
|
||||
["role"] = isAssistant ? "assistant" : "user",
|
||||
["content"] = new JsonArray
|
||||
{
|
||||
new JsonObject
|
||||
{
|
||||
["type"] = isAssistant ? "output_text" : "input_text",
|
||||
["text"] = text
|
||||
}
|
||||
}
|
||||
["role"] = role == ChatRole.Assistant.Value ? "assistant" : "user",
|
||||
["content"] = text
|
||||
});
|
||||
}
|
||||
|
||||
@@ -697,7 +665,7 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
["type"] = "function_call",
|
||||
["call_id"] = call.CallId,
|
||||
["name"] = call.Name,
|
||||
["arguments"] = SerializeFunctionArguments(call)
|
||||
["arguments"] = JsonSerializer.Serialize(call.Arguments, JsonOptions)
|
||||
});
|
||||
}
|
||||
else if (content is FunctionResultContent result)
|
||||
@@ -734,15 +702,110 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
return result;
|
||||
}
|
||||
|
||||
private static string SerializeFunctionArguments(FunctionCallContent call)
|
||||
private static void AddMessageContent(List<AIContent> contents, JsonElement item)
|
||||
{
|
||||
if (call.RawRepresentation is FunctionCallResponseItem responseItem
|
||||
&& responseItem.FunctionArguments is not null)
|
||||
if (!item.TryGetProperty("content", out var messageContent) || messageContent.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
return responseItem.FunctionArguments.ToString();
|
||||
return;
|
||||
}
|
||||
|
||||
return JsonSerializer.Serialize(call.Arguments, JsonOptions);
|
||||
foreach (var content in messageContent.EnumerateArray())
|
||||
{
|
||||
if (GetString(content, "type") == "output_text")
|
||||
{
|
||||
var text = GetString(content, "text");
|
||||
if (!string.IsNullOrEmpty(text))
|
||||
{
|
||||
contents.Add(new TextContent(text));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static void AddVisibleReasoningSummaryText(List<string> summaries, JsonElement item)
|
||||
{
|
||||
AddVisibleReasoningSummaryText(summaries, item, "summary");
|
||||
AddVisibleReasoningSummaryText(summaries, item, "content");
|
||||
}
|
||||
|
||||
private static void AddVisibleReasoningSummaryText(
|
||||
List<string> summaries,
|
||||
JsonElement item,
|
||||
string propertyName)
|
||||
{
|
||||
if (!item.TryGetProperty(propertyName, out var property))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (property.ValueKind == JsonValueKind.String)
|
||||
{
|
||||
AddNonEmpty(summaries, property.GetString());
|
||||
return;
|
||||
}
|
||||
|
||||
if (property.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
foreach (var summaryItem in property.EnumerateArray())
|
||||
{
|
||||
if (summaryItem.ValueKind == JsonValueKind.String)
|
||||
{
|
||||
AddNonEmpty(summaries, summaryItem.GetString());
|
||||
}
|
||||
else if (summaryItem.ValueKind == JsonValueKind.Object)
|
||||
{
|
||||
if (propertyName == "content" && !IsSummaryContent(summaryItem))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
AddNonEmpty(summaries, GetString(summaryItem, "text"));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static bool IsSummaryContent(JsonElement item)
|
||||
{
|
||||
var type = GetString(item, "type");
|
||||
return !string.IsNullOrWhiteSpace(type)
|
||||
&& type.Contains("summary", StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
private static void AddNonEmpty(List<string> values, string? value)
|
||||
{
|
||||
if (!string.IsNullOrWhiteSpace(value))
|
||||
{
|
||||
values.Add(value.Trim());
|
||||
}
|
||||
}
|
||||
|
||||
private static Dictionary<string, object?> ParseArguments(string? arguments)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(arguments))
|
||||
{
|
||||
return [];
|
||||
}
|
||||
|
||||
using var document = JsonDocument.Parse(arguments);
|
||||
return document.RootElement.EnumerateObject()
|
||||
.ToDictionary(property => property.Name, property => ConvertJsonValue(property.Value));
|
||||
}
|
||||
|
||||
private static object? ConvertJsonValue(JsonElement element)
|
||||
{
|
||||
return element.ValueKind switch
|
||||
{
|
||||
JsonValueKind.String => element.GetString(),
|
||||
JsonValueKind.Number when element.TryGetInt64(out var integer) => integer,
|
||||
JsonValueKind.Number when element.TryGetDouble(out var number) => number,
|
||||
JsonValueKind.True => true,
|
||||
JsonValueKind.False => false,
|
||||
JsonValueKind.Null => null,
|
||||
_ => JsonSerializer.Deserialize<object>(element.GetRawText(), JsonOptions)
|
||||
};
|
||||
}
|
||||
|
||||
private static string ResultToString(object? result)
|
||||
@@ -755,12 +818,57 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
};
|
||||
}
|
||||
|
||||
private static UsageDetails? ParseUsage(JsonElement root)
|
||||
{
|
||||
if (!root.TryGetProperty("usage", out var usage) || usage.ValueKind != JsonValueKind.Object)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var inputTokens = GetInt(usage, "input_tokens") ?? GetInt(usage, "prompt_tokens");
|
||||
var outputTokens = GetInt(usage, "output_tokens") ?? GetInt(usage, "completion_tokens");
|
||||
var totalTokens = GetInt(usage, "total_tokens");
|
||||
return new UsageDetails
|
||||
{
|
||||
InputTokenCount = inputTokens,
|
||||
OutputTokenCount = outputTokens,
|
||||
TotalTokenCount = totalTokens
|
||||
};
|
||||
}
|
||||
|
||||
private static int EstimateTokens(JsonObject payload)
|
||||
{
|
||||
var json = payload.ToJsonString(JsonOptions);
|
||||
return Math.Max(1, (int)Math.Ceiling(json.Length / 4.0));
|
||||
}
|
||||
|
||||
private static int? GetInt(JsonElement element, string propertyName)
|
||||
{
|
||||
return element.TryGetProperty(propertyName, out var property) && property.TryGetInt32(out var value)
|
||||
? value
|
||||
: null;
|
||||
}
|
||||
|
||||
private static string GetRequiredString(JsonElement element, string propertyName)
|
||||
{
|
||||
return GetString(element, propertyName)
|
||||
?? throw new InvalidOperationException($"LiteLLM response item did not include '{propertyName}'.");
|
||||
}
|
||||
|
||||
private static string? GetString(JsonElement element, string propertyName)
|
||||
{
|
||||
return element.TryGetProperty(propertyName, out var property) && property.ValueKind == JsonValueKind.String
|
||||
? property.GetString()
|
||||
: null;
|
||||
}
|
||||
|
||||
private static DateTimeOffset? GetUnixTimestamp(JsonElement element, string propertyName)
|
||||
{
|
||||
return element.TryGetProperty(propertyName, out var property) && property.TryGetInt64(out var value)
|
||||
? DateTimeOffset.FromUnixTimeSeconds(value)
|
||||
: null;
|
||||
}
|
||||
|
||||
private static Uri NormalizeEndpoint(Uri endpoint)
|
||||
{
|
||||
var value = endpoint.ToString().TrimEnd('/');
|
||||
@@ -776,60 +884,5 @@ public sealed class LiteLlmResponsesChatClient : IChatClient
|
||||
{
|
||||
return value.TrimStart('/');
|
||||
}
|
||||
|
||||
private static ResponsesClient CreateResponsesClient(
|
||||
HttpClient httpClient,
|
||||
string apiKey,
|
||||
AsyncLocal<string?> requestInitiator)
|
||||
{
|
||||
var options = new OpenAIClientOptions
|
||||
{
|
||||
Endpoint = httpClient.BaseAddress
|
||||
?? throw new InvalidOperationException("LiteLLM HTTP client requires a base address."),
|
||||
Transport = new HttpClientPipelineTransport(httpClient),
|
||||
RetryPolicy = new ClientRetryPolicy(0)
|
||||
};
|
||||
options.AddPolicy(
|
||||
new InitiatorHeaderPolicy(requestInitiator),
|
||||
PipelinePosition.PerCall);
|
||||
|
||||
return new ResponsesClient(
|
||||
new ApiKeyCredential(apiKey),
|
||||
options);
|
||||
}
|
||||
|
||||
private sealed record ResponsesChatResult(
|
||||
ChatResponse Response,
|
||||
IReadOnlyList<string> ReasoningSummaries);
|
||||
|
||||
private sealed class InitiatorHeaderPolicy(AsyncLocal<string?> requestInitiator) : PipelinePolicy
|
||||
{
|
||||
public override void Process(
|
||||
PipelineMessage message,
|
||||
IReadOnlyList<PipelinePolicy> pipeline,
|
||||
int currentIndex)
|
||||
{
|
||||
SetHeader(message);
|
||||
ProcessNext(message, pipeline, currentIndex);
|
||||
}
|
||||
|
||||
public override ValueTask ProcessAsync(
|
||||
PipelineMessage message,
|
||||
IReadOnlyList<PipelinePolicy> pipeline,
|
||||
int currentIndex)
|
||||
{
|
||||
SetHeader(message);
|
||||
return ProcessNextAsync(message, pipeline, currentIndex);
|
||||
}
|
||||
|
||||
private void SetHeader(PipelineMessage message)
|
||||
{
|
||||
if (!string.IsNullOrWhiteSpace(requestInitiator.Value))
|
||||
{
|
||||
message.Request.Headers.Set("X-Initiator", requestInitiator.Value);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
#pragma warning restore OPENAI001
|
||||
#pragma warning restore MAAI001
|
||||
|
||||
@@ -63,24 +63,32 @@ public sealed class OpenAiMeetingSummaryAgentPipeline : IMeetingSummaryPipeline
|
||||
meetingWorkflowEngine);
|
||||
var tools = CreateTools(meetingTools);
|
||||
var instructions = await instructionBuilder.BuildAsync(artifacts, options, cancellationToken);
|
||||
using var compactionSummaryClient = LiteLlmResponsesChatClient.Create(
|
||||
agentOptions,
|
||||
using var compactionSummaryClient = new LiteLlmResponsesChatClient(
|
||||
new Uri(agentOptions.Endpoint),
|
||||
key,
|
||||
agentOptions.Model,
|
||||
agentOptions.EnableThinking,
|
||||
ToReasoningEffortValue(agentOptions.ReasoningEffort),
|
||||
agentOptions.ReconnectionAttempts,
|
||||
agentOptions.ReconnectionDelay,
|
||||
compactionOptions: null,
|
||||
logger,
|
||||
firstRequestIsUser: false);
|
||||
var compactionOptions = CreateCompactionOptions(agentOptions, compactionSummaryClient);
|
||||
using var chatClient = LiteLlmResponsesChatClient.Create(
|
||||
agentOptions,
|
||||
using var chatClient = new LiteLlmResponsesChatClient(
|
||||
new Uri(agentOptions.Endpoint),
|
||||
key,
|
||||
agentOptions.Model,
|
||||
agentOptions.EnableThinking,
|
||||
ToReasoningEffortValue(agentOptions.ReasoningEffort),
|
||||
agentOptions.ReconnectionAttempts,
|
||||
agentOptions.ReconnectionDelay,
|
||||
compactionOptions,
|
||||
logger,
|
||||
firstRequestIsUser: false);
|
||||
var agent = chatClient
|
||||
.AsBuilder()
|
||||
.UseFunctionInvocation(
|
||||
loggerFactory,
|
||||
client => client.FunctionInvoker = FunctionInvocationGuard.InvokeAsync)
|
||||
.UseFunctionInvocation()
|
||||
.Build()
|
||||
.AsAIAgent(
|
||||
instructions,
|
||||
@@ -304,6 +312,18 @@ public sealed class OpenAiMeetingSummaryAgentPipeline : IMeetingSummaryPipeline
|
||||
return new PipelineCompactionStrategy(strategies);
|
||||
}
|
||||
|
||||
private static string ToReasoningEffortValue(ReasoningEffortOption effort)
|
||||
{
|
||||
return effort switch
|
||||
{
|
||||
ReasoningEffortOption.None => "none",
|
||||
ReasoningEffortOption.Low => "low",
|
||||
ReasoningEffortOption.High => "high",
|
||||
ReasoningEffortOption.ExtraHigh => "xhigh",
|
||||
_ => "medium"
|
||||
};
|
||||
}
|
||||
|
||||
private static ReasoningEffort ToReasoningEffort(ReasoningEffortOption effort)
|
||||
{
|
||||
return effort switch
|
||||
|
||||
@@ -85,16 +85,26 @@ public sealed class WorkflowRulesEditorChatPipeline : IWorkflowRulesEditorChatPi
|
||||
.ToList();
|
||||
var instructions = await instructionBuilder.BuildAsync(options, cancellationToken);
|
||||
|
||||
using var compactionSummaryClient = LiteLlmResponsesChatClient.Create(
|
||||
agentOptions,
|
||||
using var compactionSummaryClient = new LiteLlmResponsesChatClient(
|
||||
new Uri(agentOptions.Endpoint),
|
||||
key,
|
||||
agentOptions.Model,
|
||||
agentOptions.EnableThinking,
|
||||
ToReasoningEffortValue(agentOptions.ReasoningEffort),
|
||||
agentOptions.ReconnectionAttempts,
|
||||
agentOptions.ReconnectionDelay,
|
||||
compactionOptions: null,
|
||||
logger,
|
||||
firstRequestIsUser: false);
|
||||
var compactionOptions = CreateCompactionOptions(agentOptions, compactionSummaryClient);
|
||||
using var chatClient = LiteLlmResponsesChatClient.Create(
|
||||
agentOptions,
|
||||
using var chatClient = new LiteLlmResponsesChatClient(
|
||||
new Uri(agentOptions.Endpoint),
|
||||
key,
|
||||
agentOptions.Model,
|
||||
agentOptions.EnableThinking,
|
||||
ToReasoningEffortValue(agentOptions.ReasoningEffort),
|
||||
agentOptions.ReconnectionAttempts,
|
||||
agentOptions.ReconnectionDelay,
|
||||
compactionOptions,
|
||||
logger,
|
||||
firstRequestIsUser: true,
|
||||
@@ -106,12 +116,8 @@ public sealed class WorkflowRulesEditorChatPipeline : IWorkflowRulesEditorChatPi
|
||||
{
|
||||
client.FunctionInvoker = async (context, token) =>
|
||||
{
|
||||
if (context.CallContent.Exception is null)
|
||||
{
|
||||
activityChanged?.Invoke(WorkflowRulesEditorActivityUpdate.ToolCall(context.Function.Name));
|
||||
}
|
||||
|
||||
return await FunctionInvocationGuard.InvokeAsync(context, token);
|
||||
activityChanged?.Invoke(WorkflowRulesEditorActivityUpdate.ToolCall(context.Function.Name));
|
||||
return await context.Function.InvokeAsync(context.Arguments, token);
|
||||
};
|
||||
})
|
||||
.Build();
|
||||
@@ -390,6 +396,18 @@ public sealed class WorkflowRulesEditorChatPipeline : IWorkflowRulesEditorChatPi
|
||||
$"No {agentName} API key configured. Set MeetingAssistant:WorkflowRulesEditor:Key, MeetingAssistant:Agent:Key, or environment variable '{options.KeyEnv}'.");
|
||||
}
|
||||
|
||||
private static string ToReasoningEffortValue(ReasoningEffortOption effort)
|
||||
{
|
||||
return effort switch
|
||||
{
|
||||
ReasoningEffortOption.None => "none",
|
||||
ReasoningEffortOption.Low => "low",
|
||||
ReasoningEffortOption.High => "high",
|
||||
ReasoningEffortOption.ExtraHigh => "xhigh",
|
||||
_ => "medium"
|
||||
};
|
||||
}
|
||||
|
||||
private static ReasoningEffort ToReasoningEffort(ReasoningEffortOption effort)
|
||||
{
|
||||
return effort switch
|
||||
|
||||
@@ -172,7 +172,6 @@
|
||||
"Endpoint": "http://127.0.0.1:4021",
|
||||
"KeyEnv": "LITELLM_API_KEY",
|
||||
"Model": "chatgpt/gpt-5.5",
|
||||
"UseStreaming": true,
|
||||
"EnableThinking": true,
|
||||
"ReasoningEffort": "Medium",
|
||||
"ReconnectionAttempts": 2,
|
||||
|
||||
@@ -339,7 +339,6 @@ When enabled on Windows, Meeting Assistant periodically syncs today's Outlook Cl
|
||||
| `Key` | Optional inline API key. Prefer `KeyEnv`. |
|
||||
| `KeyEnv` | Environment variable name for the agent API key. |
|
||||
| `Model` | Model id sent to the endpoint. |
|
||||
| `UseStreaming` | Uses the Responses SSE transport when `true` (the default); uses the non-streaming Responses transport when `false`. |
|
||||
| `EnableThinking` | Enables reasoning options in requests when supported by the model/backend. |
|
||||
| `ReasoningEffort` | Reasoning effort: `None`, `Low`, `Medium`, `High`, or `ExtraHigh`. |
|
||||
| `ReconnectionAttempts` | Retry count for transient model endpoint failures. |
|
||||
@@ -361,9 +360,9 @@ The summary agent can add and remove meeting-note attendees when transcript or O
|
||||
|
||||
## Workflow Rules Editor
|
||||
|
||||
`WorkflowRulesEditor` configures the tray-launched `Meeting Summary Agent` window. Blank values inherit from `Agent`, so it uses the summarizer endpoint, key, model, Responses transport, reasoning, retry, output, and compaction settings unless explicitly overridden.
|
||||
`WorkflowRulesEditor` configures the tray-launched `Meeting Summary Agent` window. Blank values inherit from `Agent`, so it uses the summarizer endpoint, key, model, reasoning, retry, output, and compaction settings unless explicitly overridden.
|
||||
|
||||
The overridable fields are `Endpoint`, `Key`, `KeyEnv`, `Model`, `UseStreaming`, `EnableThinking`, `ReasoningEffort`, `ReconnectionAttempts`, `ReconnectionDelay`, `ContextWindowTokens`, `MaxOutputTokens`, `EnableCompaction`, `CompactionRemainingRatio`, `ResponsesCompactPath`, and `InitialPrompt`.
|
||||
The overridable fields are `Endpoint`, `Key`, `KeyEnv`, `Model`, `EnableThinking`, `ReasoningEffort`, `ReconnectionAttempts`, `ReconnectionDelay`, `ContextWindowTokens`, `MaxOutputTokens`, `EnableCompaction`, `CompactionRemainingRatio`, `ResponsesCompactPath`, and `InitialPrompt`.
|
||||
|
||||
The assistant can edit workflow rules, manage speaker identities, read and replace the local appsettings file, read this configuration document, search and read copied OpenSpec specs, inspect application logs, create/search/read/write project files, and post-process past meeting artifacts by listing recent summaries and reading, writing, or searching summaries, transcripts, meeting notes, and assistant context files. For artifact metadata repairs, it has frontmatter-specific write tools that preserve the markdown body.
|
||||
|
||||
|
||||
@@ -31,7 +31,6 @@ The tray menu includes `Open agent`, which opens the `Meeting Summary Agent` cha
|
||||
"Endpoint": "",
|
||||
"KeyEnv": "",
|
||||
"Model": "",
|
||||
"UseStreaming": null,
|
||||
"EnableThinking": null,
|
||||
"ReasoningEffort": null,
|
||||
"MaxOutputTokens": null,
|
||||
|
||||
@@ -1,2 +0,0 @@
|
||||
schema: spec-driven
|
||||
created: 2026-07-27
|
||||
@@ -1,40 +0,0 @@
|
||||
## Context
|
||||
|
||||
`LiteLlmResponsesChatClient` exposes a non-streaming `IChatClient` interface and currently buffers every successful `/v1/responses` body before parsing it as one JSON document. The deployed LiteLLM `chatgpt/gpt-5.5` route instead returns Responses Server-Sent Events. Microsoft.Extensions.AI.OpenAI already provides a Responses streaming adapter that maps the OpenAI SDK's typed SSE updates into `ChatResponseUpdate` values, including text, reasoning, function calls, response metadata, and usage.
|
||||
|
||||
That adapter uses `FunctionCallContent.CreateFromParsedArguments`, which records argument-mapping failures on the function call instead of throwing them from the response parser. The default function invoker does not itself prevent invocation when that property is populated, so Meeting Assistant must turn the recorded parse failure into a matching function result before calling the tool.
|
||||
|
||||
## Goals / Non-Goals
|
||||
|
||||
**Goals:**
|
||||
|
||||
- Preserve the existing non-streaming `IChatClient` contract while selecting the supported Responses streaming or non-streaming path through configuration.
|
||||
- Delegate SSE framing, event deserialization, streamed function-call assembly, response metadata, and usage mapping to the OpenAI SDK and Microsoft.Extensions.AI.OpenAI adapter.
|
||||
- Preserve the original encoded function arguments when forwarding conversation history.
|
||||
- Return a safe, structured invalid-arguments result for malformed argument JSON without invoking the requested tool.
|
||||
- Apply the guarded invocation behavior to both summary and workflow-editor agent pipelines that use this Responses client.
|
||||
|
||||
**Non-Goals:**
|
||||
|
||||
- Expose token-by-token upstream streaming to the UI.
|
||||
- Replace Microsoft.Extensions.AI function invocation or implement general JSON Schema validation.
|
||||
- Recover from an incomplete or malformed Responses event stream that has no usable completed output.
|
||||
|
||||
## Decisions
|
||||
|
||||
1. Add `Agent:UseStreaming`, defaulting to `true`, and send summary requests through the matching OpenAI SDK method. The streaming path uses `ResponsesClient.CreateResponseStreamingAsync` and collects the Microsoft.Extensions.AI.OpenAI typed updates into one `ChatResponse`; the non-streaming path uses `ResponsesClient.CreateResponseAsync` and its supported `AsChatResponse` adapter.
|
||||
|
||||
2. Keep the existing JSON payload builder because it owns Meeting Assistant-specific compaction input, tool serialization, reasoning settings, retry diagnostics, and initiator behavior. Deserialize that payload into the OpenAI SDK's `CreateResponseOptions`, set its streaming flag from configuration, and let the selected SDK method own the HTTP response protocol.
|
||||
|
||||
The SDK deserializes `ResponseItem` values by their `type` discriminator. Message items must therefore include `"type": "message"` before the JSON payload is converted to `CreateResponseOptions`; otherwise the SDK reserializes them as `"type": "unknown"` and the provider rejects the request.
|
||||
|
||||
3. Rely on the framework adapter's `FunctionCallContent.CreateFromParsedArguments` mapping for function-call argument decoding and raw response preservation. A shared function-invocation callback checks the recorded parse exception before invocation. For invalid JSON it returns a structured `invalid_tool_arguments` value that the framework associates with the original call ID; otherwise it delegates to the actual function.
|
||||
|
||||
4. Configure both agent pipelines with the shared guarded invoker. This avoids duplicating the safety decision and prevents zero-argument tools from accidentally running when malformed JSON would otherwise map to an empty argument set.
|
||||
|
||||
## Risks / Trade-offs
|
||||
|
||||
- **[Provider event variants]** A provider could emit events outside the OpenAI Responses schema. → Use the maintained OpenAI SDK parser and fail diagnostically for genuinely incompatible streams instead of maintaining local event variants.
|
||||
- **[Buffered result]** The summary pipeline does not expose token-by-token updates to its caller. → Collect the framework updates only at the existing non-streaming boundary; the HTTP response itself remains streamed and incrementally parsed.
|
||||
- **[Experimental API]** The OpenAI Responses adapter is marked experimental in the currently referenced package. → Keep it behind `LiteLlmResponsesChatClient`, which isolates future package API changes from the rest of Meeting Assistant.
|
||||
- **[Error disclosure]** Raw parser exceptions may contain implementation details. → Return a stable error code and concise validation message rather than exception text or the malformed arguments.
|
||||
@@ -1,26 +0,0 @@
|
||||
## Why
|
||||
|
||||
The configured LiteLLM Responses endpoint can return successful responses as Server-Sent Events even when the request sets `stream: false`. Meeting Assistant currently treats every successful body as one JSON document, and it also lets malformed function-call argument JSON escape as a fatal parse exception, so either condition can abort an otherwise recoverable summary run.
|
||||
|
||||
## What Changes
|
||||
|
||||
- Consume the configured LiteLLM Responses endpoint through the supported OpenAI Responses streaming transport and Agent Framework adapter.
|
||||
- Assemble completed response output items and usage metadata from Responses SSE events before returning them through the existing non-streaming chat-client interface.
|
||||
- Add an agent setting that selects streaming or non-streaming Responses transport, with streaming enabled by default.
|
||||
- Preserve valid Responses item discriminators when translating agent messages through the OpenAI SDK request model.
|
||||
- Treat malformed function-call arguments as invalid tool input that is returned to the agent for correction without invoking the tool or terminating the summary run.
|
||||
- Add behavior tests for streamed text, streamed function calls, and invalid function-call arguments.
|
||||
|
||||
## Capabilities
|
||||
|
||||
### New Capabilities
|
||||
|
||||
- None.
|
||||
|
||||
### Modified Capabilities
|
||||
|
||||
- `meeting-summary`: Make the existing Responses-based summary pipeline interoperable with SSE responses and resilient to malformed tool-call input.
|
||||
|
||||
## Impact
|
||||
|
||||
The change affects agent configuration, the custom LiteLLM Responses chat client, its summary-agent integration, and focused tests. It does not change the public HTTP API.
|
||||
-36
@@ -1,36 +0,0 @@
|
||||
## ADDED Requirements
|
||||
|
||||
### Requirement: Summary agents tolerate Responses event streams and malformed tool arguments
|
||||
Meeting Assistant SHALL consume successful summary-agent Responses results through the supported OpenAI Responses and Agent Framework Server-Sent Events adapter.
|
||||
|
||||
When a Responses event stream delivers completed output items separately from the final response metadata, Meeting Assistant SHALL assemble those output items into one agent response while preserving final response metadata and usage.
|
||||
|
||||
Meeting Assistant SHALL provide an agent setting that selects streaming or non-streaming Responses transport. Streaming SHALL be enabled by default. When streaming is disabled, Meeting Assistant SHALL use the supported non-streaming OpenAI Responses client and adapter.
|
||||
|
||||
When a returned function call contains arguments that are not a valid JSON object, Meeting Assistant SHALL NOT invoke the requested function and SHALL return an invalid-tool-arguments result associated with the original call ID to the agent so it can correct the call.
|
||||
|
||||
When Meeting Assistant translates chat messages into a Responses request, every message input item SHALL retain the `message` item discriminator required by the OpenAI SDK and Responses API.
|
||||
|
||||
#### Scenario: Streamed text response is assembled
|
||||
- **WHEN** the configured Responses endpoint returns completed message output in Server-Sent Events followed by final response metadata
|
||||
- **THEN** the summary agent receives the completed message text, response metadata, and usage without a JSON document parse failure
|
||||
|
||||
#### Scenario: Streamed function call is assembled
|
||||
- **WHEN** the configured Responses endpoint returns a completed function-call output item in Server-Sent Events
|
||||
- **THEN** the summary agent receives the function call with its call ID, function name, and parsed arguments
|
||||
|
||||
#### Scenario: Streaming transport can be disabled
|
||||
- **WHEN** `MeetingAssistant:Agent:UseStreaming` is `false`
|
||||
- **THEN** the summary agent requests a non-streaming Responses result
|
||||
- **AND** converts the response through the supported OpenAI Responses adapter
|
||||
|
||||
#### Scenario: Chat message input remains a Responses message
|
||||
- **WHEN** the summary agent sends a user or assistant chat message through the Responses client
|
||||
- **THEN** the outbound Responses input item has type `message`
|
||||
- **AND** the request does not contain an `unknown` input item type
|
||||
|
||||
#### Scenario: Malformed function arguments are returned to the agent
|
||||
- **WHEN** the model returns a function call whose arguments are not a valid JSON object
|
||||
- **THEN** Meeting Assistant does not invoke the requested function
|
||||
- **AND** sends a function result with an invalid-tool-arguments error for the original call ID back to the agent
|
||||
- **AND** allows the agent loop to continue
|
||||
@@ -1,24 +0,0 @@
|
||||
## 1. Responses SSE compatibility
|
||||
|
||||
- [x] 1.1 Add a failing client behavior test for a streamed text response with final metadata and usage.
|
||||
- [x] 1.2 Add failing configuration and client behavior tests for selecting non-streaming Responses transport.
|
||||
- [x] 1.3 Route Responses requests through the Agent Framework/OpenAI SDK streaming or non-streaming adapter according to configuration.
|
||||
- [x] 1.4 Add behavior coverage for streamed function-call output.
|
||||
|
||||
## 2. Invalid tool-argument recovery
|
||||
|
||||
- [x] 2.1 Add a failing agent-loop behavior test proving malformed function-call JSON does not invoke the tool and is returned to the agent.
|
||||
- [x] 2.2 Preserve argument parse failures on function-call content and add the shared guarded function invoker.
|
||||
- [x] 2.3 Apply guarded function invocation to the summary and workflow-editor agent pipelines.
|
||||
|
||||
## 3. Verification
|
||||
|
||||
- [x] 3.1 Refactor the touched response and invocation paths for DRYness, SOLID boundaries, and simplicity while preserving behavior.
|
||||
- [x] 3.2 Run focused tests, the full solution tests, and strict OpenSpec validation.
|
||||
- [x] 3.3 Verify the client behavior against the deployed LiteLLM Responses endpoint and restart Meeting Assistant only after confirming it is idle.
|
||||
|
||||
## 4. Responses message-item compatibility
|
||||
|
||||
- [x] 4.1 Add a failing client behavior test proving an outbound chat message retains the `message` discriminator through SDK serialization.
|
||||
- [x] 4.2 Emit the Responses `message` discriminator for chat message input items.
|
||||
- [x] 4.3 Run focused and full tests, validate OpenSpec strictly, restart while idle, and retry the failed summary through the local API.
|
||||
@@ -151,38 +151,3 @@ The built-in instructions SHALL direct the summary agent to append unexpected pr
|
||||
- **THEN** its instructions direct it to append a concise record to the meeting's assistant context
|
||||
- **AND** later agents can discover that record when working on the same meeting
|
||||
|
||||
### Requirement: Summary agents tolerate Responses event streams and malformed tool arguments
|
||||
Meeting Assistant SHALL consume successful summary-agent Responses results through the supported OpenAI Responses and Agent Framework Server-Sent Events adapter.
|
||||
|
||||
When a Responses event stream delivers completed output items separately from the final response metadata, Meeting Assistant SHALL assemble those output items into one agent response while preserving final response metadata and usage.
|
||||
|
||||
Meeting Assistant SHALL provide an agent setting that selects streaming or non-streaming Responses transport. Streaming SHALL be enabled by default. When streaming is disabled, Meeting Assistant SHALL use the supported non-streaming OpenAI Responses client and adapter.
|
||||
|
||||
When a returned function call contains arguments that are not a valid JSON object, Meeting Assistant SHALL NOT invoke the requested function and SHALL return an invalid-tool-arguments result associated with the original call ID to the agent so it can correct the call.
|
||||
|
||||
When Meeting Assistant translates chat messages into a Responses request, every message input item SHALL retain the `message` item discriminator required by the OpenAI SDK and Responses API.
|
||||
|
||||
#### Scenario: Streamed text response is assembled
|
||||
- **WHEN** the configured Responses endpoint returns completed message output in Server-Sent Events followed by final response metadata
|
||||
- **THEN** the summary agent receives the completed message text, response metadata, and usage without a JSON document parse failure
|
||||
|
||||
#### Scenario: Streamed function call is assembled
|
||||
- **WHEN** the configured Responses endpoint returns a completed function-call output item in Server-Sent Events
|
||||
- **THEN** the summary agent receives the function call with its call ID, function name, and parsed arguments
|
||||
|
||||
#### Scenario: Streaming transport can be disabled
|
||||
- **WHEN** `MeetingAssistant:Agent:UseStreaming` is `false`
|
||||
- **THEN** the summary agent requests a non-streaming Responses result
|
||||
- **AND** converts the response through the supported OpenAI Responses adapter
|
||||
|
||||
#### Scenario: Chat message input remains a Responses message
|
||||
- **WHEN** the summary agent sends a user or assistant chat message through the Responses client
|
||||
- **THEN** the outbound Responses input item has type `message`
|
||||
- **AND** the request does not contain an `unknown` input item type
|
||||
|
||||
#### Scenario: Malformed function arguments are returned to the agent
|
||||
- **WHEN** the model returns a function call whose arguments are not a valid JSON object
|
||||
- **THEN** Meeting Assistant does not invoke the requested function
|
||||
- **AND** sends a function result with an invalid-tool-arguments error for the original call ID back to the agent
|
||||
- **AND** allows the agent loop to continue
|
||||
|
||||
|
||||
Reference in New Issue
Block a user